Fix serde recursion limit test by using correct MAX_RECURSION_DEPTH #61182
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eason09053360
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
amoghrajesh
reviewed
Jan 29, 2026
Comment on lines
+678
to
+681
| def test_serde_serialize_recursion_limit(self): | ||
| depth = MAX_RECURSION_DEPTH | ||
| with pytest.raises(RecursionError, match="maximum recursion depth reached for serialization"): | ||
| serialize(object(), depth=depth) |
Contributor
There was a problem hiding this comment.
Are you fixing a test or adding a new one?
Author
There was a problem hiding this comment.
I am fixing a test (readding a previously removed flaky test with a fix)
Contributor
There was a problem hiding this comment.
@amoghrajesh It’s more like a fix, I think, because someone found this test was flaky and just deleted it.
FYI #51737
Contributor
There was a problem hiding this comment.
Thanks, yes it shouldnt have been deleted!
amoghrajesh
approved these changes
Jan 30, 2026
Comment on lines
+678
to
+681
| def test_serde_serialize_recursion_limit(self): | ||
| depth = MAX_RECURSION_DEPTH | ||
| with pytest.raises(RecursionError, match="maximum recursion depth reached for serialization"): | ||
| serialize(object(), depth=depth) |
Contributor
There was a problem hiding this comment.
Thanks, yes it shouldnt have been deleted!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky unit test
test_serde_serialize_recursion_limitintask-sdk.The test was previously using
sys.getrecursionlimit() - 1to simulate the recursion depth. However, this system limit (often 1000) does not match the internalMAX_RECURSION_DEPTHconstant (which is 10) used in theserializefunction.Because of this mismatch, the
depthcheck inserializepassed (since 999 != 10), causing the function to attempt to serialize the emptyobject(), resulting in aTypeErrorinstead of the expectedRecursionError.Verification
Ran the test locally with
pytestand it passed:Changes:
MAX_RECURSION_DEPTHfromairflow.sdk.serde.serde.depthparameter to correctly trigger theRecursionError.closes: #51915