Skip to content

Fix airflowctl auth login failing with trailing slash in api-url #61245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bugraoz93 merged 1 commit into from
Jan 30, 2026
Merged

Fix airflowctl auth login failing with trailing slash in api-url #61245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airflow-ctl/src/airflowctl/api/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ def _get_base_url(
cls, base_url: str, kind: Literal[ClientKind.AUTH, ClientKind.CLI] = ClientKind.CLI
) -> str:
"""Get the base URL of the client."""
base_url = base_url.rstrip("/")
if kind == ClientKind.AUTH:
return f"{base_url}/auth"
return f"{base_url}/api/v2"
Expand Down
4 changes: 4 additions & 0 deletions airflow-ctl/tests/airflow_ctl/api/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ def handle_request(request: httpx.Request) -> httpx.Response:
("http://localhost:8080", ClientKind.AUTH, "http://localhost:8080/auth/"),
("https://example.com", ClientKind.CLI, "https://example.com/api/v2/"),
("https://example.com", ClientKind.AUTH, "https://example.com/auth/"),
("http://localhost:8080/", ClientKind.CLI, "http://localhost:8080/api/v2/"),
("http://localhost:8080/", ClientKind.AUTH, "http://localhost:8080/auth/"),
("https://example.com/", ClientKind.CLI, "https://example.com/api/v2/"),
("https://example.com/", ClientKind.AUTH, "https://example.com/auth/"),
],
)
def test_refresh_base_url(self, base_url, client_kind, expected_base_url):
Expand Down