Skip to content

Comments

Fix airflowctl auth login reporting success when keyring backend is unavailable#61296

Merged
dheerajturaga merged 1 commit intoapache:mainfrom
dheerajturaga:bugfix/missing-keyring-login
Jan 31, 2026
Merged

Fix airflowctl auth login reporting success when keyring backend is unavailable#61296
dheerajturaga merged 1 commit intoapache:mainfrom
dheerajturaga:bugfix/missing-keyring-login

Conversation

@dheerajturaga
Copy link
Member

Credentials.save() caught NoKeyringError and logged it without re-raising, so the login command never saw the failure and printed "Login successful!" despite the token never being persisted.

2026-01-31 17:14:06 [error    ] No keyring backend available: No recommended backend was available. Install a recommended 3rd party backend package; or, install the keyrings.alt package if you want to use the non-recommended backends. See https://pypi.org/project/keyring for details. [airflowctl.api.client]
2026-01-31 17:14:06 [error    ] No recommended backend was available. Install a recommended 3rd party backend package; or, install the keyrings.alt package if you want to use the non-recommended backends. See https://pypi.org/project/keyring for details. [airflowctl.api.client]
2026-01-31 17:14:06 [error    ] No recommended backend was available. Install a recommended 3rd party backend package; or, install the keyrings.alt package if you want to use the non-recommended backends. See https://pypi.org/project/keyring for details. [airflowctl.api.client]
Login successful! Welcome to airflowctl

Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one! Thanks!

@dheerajturaga dheerajturaga merged commit 262ce59 into apache:main Jan 31, 2026
82 checks passed
@dheerajturaga dheerajturaga deleted the bugfix/missing-keyring-login branch January 31, 2026 23:04
morelgeorge pushed a commit to morelgeorge/airflow that referenced this pull request Feb 1, 2026
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants