Skip to content

Fix Keycloak double-slash URL bug (#61121) #61305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 2 commits into from
Feb 2, 2026
+28 −1
Merged

Fix Keycloak double-slash URL bug (#61121) #61305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfcb9f6
Fix Keycloak double-slash URL bug (#61121)
y-sudharshan Feb 1, 2026
1d3bcac
Refactor URL normalization tests to use parametrize
y-sudharshan Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion providers/keycloak/src/airflow/providers/keycloak/auth_manager/keycloak_auth_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,8 @@ def _is_batch_authorized(

@staticmethod
def _get_token_url(server_url, realm):
return f"{server_url}/realms/{realm}/protocol/openid-connect/token"
# Normalize server_url to avoid double slashes (required for Keycloak 26.4+ strict path validation).
return f"{server_url.rstrip('/')}/realms/{realm}/protocol/openid-connect/token"

@staticmethod
def _get_payload(client_id: str, permission: str, attributes: dict[str, str] | None = None):
Expand Down
26 changes: 26 additions & 0 deletions providers/keycloak/tests/unit/keycloak/auth_manager/test_keycloak_auth_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,3 +559,29 @@ def test_get_keycloak_client_with_no_credentials(self, mock_keycloak_openid, aut
client_secret_key="client_secret",
)
assert client == mock_keycloak_openid.return_value

@pytest.mark.parametrize(
("server_url", "expected_url"),
[
(
"https://keycloak.example.com/auth",
"https://keycloak.example.com/auth/realms/myrealm/protocol/openid-connect/token",
),
(
"https://keycloak.example.com/auth/",
"https://keycloak.example.com/auth/realms/myrealm/protocol/openid-connect/token",
),
(
"https://keycloak.example.com/auth///",
"https://keycloak.example.com/auth/realms/myrealm/protocol/openid-connect/token",
),
(
"https://keycloak.example.com/",
"https://keycloak.example.com/realms/myrealm/protocol/openid-connect/token",
),
],
)
def test_get_token_url_normalization(self, auth_manager, server_url, expected_url):
"""Test that _get_token_url normalizes server_url by stripping trailing slashes."""
token_url = auth_manager._get_token_url(server_url, "myrealm")
assert token_url == expected_url