Return GCS URIs from GoogleAdsToGcsOperator for Issue #11323#61334
Return GCS URIs from GoogleAdsToGcsOperator for Issue #11323#61334Abhishekmishra2808 wants to merge 3 commits intoapache:mainfrom
Conversation
shahar1
left a comment
There was a problem hiding this comment.
You're in the way, but there's some work to so :)
Also, please fix static checks using prek (instructions are available in the docs)
providers/google/src/airflow/providers/google/ads/transfers/ads_to_gcs.py
Show resolved
Hide resolved
|
2d84e84 to
83e9ed4
Compare
- Update execute() return type from None to list[str] - Return list containing full gs:// URI of uploaded file - Add docstring documenting return value - Update unit test to validate return value format - Fix BUCKET test constant (removed gs:// prefix)
…erator - Add unwrap_single keyword-only parameter to __init__ (default=False) - Update execute() return type to str | list[str] - Implement conditional return logic: - Returns str when unwrap_single=True - Returns list[str] by default (backward compatible) - Add comprehensive docstring updates - Add test_execute_with_unwrap_single() to validate new behavior - Maintain backward compatibility with existing code Follows the pattern used in PR apache#61284
83e9ed4 to
f3b5fc9
Compare
PR Update
GoogleAdsToGcsOperator.execute()return type fromNonetolist[str]gs://URI of the uploaded GCS objectBUCKETconstant by removing thegs://prefixRelated: #11323