Skip to content

Comments

Return list of destination URIs from LocalFilesystemToGCSOperator#61355

Merged
shahar1 merged 2 commits intoapache:mainfrom
yuseok89:fix/11323-local-to-gcs-return-destination-uris
Feb 10, 2026
Merged

Return list of destination URIs from LocalFilesystemToGCSOperator#61355
shahar1 merged 2 commits intoapache:mainfrom
yuseok89:fix/11323-local-to-gcs-return-destination-uris

Conversation

@yuseok89
Copy link
Contributor

@yuseok89 yuseok89 commented Feb 2, 2026

Related: #11323

  • Return value: execute() now returns a list[str] of destination URIs for uploaded files (single file, list of files, or glob). This operator did not return a value before, so unwrap_single was not added..

  • Deduplication for multi-file upload: When multiple source paths map to the same destination (e.g. src=["a.png", "a.png"] or src=["data/foo.png", "data/*"] with data/ containing only foo.png), the same URI can appear more than once. The result list is deduplicated while preserving order via dict.fromkeys.


Test screenshot

image
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    • Cursor

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@yuseok89 yuseok89 requested a review from shahar1 as a code owner February 2, 2026 15:04
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Feb 2, 2026
Copy link
Contributor

@bugraoz93 bugraoz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would be good to get a stamp from @shahar1 too!

Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Are you able to run the system tests for the related operator with the new change and attach a screenshot that they pass? Please let us know if it's an issue.
Didn't notice the screenshot, LGTM!

CC: @VladaZakharova @MaksYermak - WDYT?
If no objections are made, as both CI and system tests passed - this PR will be merged by the upcoming release on Tuesday.

@shahar1 shahar1 merged commit c02000b into apache:main Feb 10, 2026
90 checks passed
Ratasa143 pushed a commit to Ratasa143/airflow that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants