Skip to content

Comments

Return list of GCS URIs from SalesforceToGcsOperator#61659

Open
Prab-27 wants to merge 1 commit intoapache:mainfrom
Prab-27:return-gcs-uri-list
Open

Return list of GCS URIs from SalesforceToGcsOperator#61659
Prab-27 wants to merge 1 commit intoapache:mainfrom
Prab-27:return-gcs-uri-list

Conversation

@Prab-27
Copy link
Contributor

@Prab-27 Prab-27 commented Feb 9, 2026

Related : #11323

It returns str | list[str] in execute method from SalesforceToGcsOperator


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Feb 9, 2026
@Prab-27
Copy link
Contributor Author

Prab-27 commented Feb 9, 2026

I need to run the system tests and unit tests .I’ll do all this once the connection is stable. It should work fine within 24 hours.

@Prab-27
Copy link
Contributor Author

Prab-27 commented Feb 18, 2026

If I can’t run system tests, I’ll run unit tests instead, fix the issue, and ask someone to run the system tests.
(Please wait a couple of days while I fix the system tests.)

@Prab-27 Prab-27 marked this pull request as ready for review February 19, 2026 13:19
@Prab-27 Prab-27 requested a review from shahar1 as a code owner February 19, 2026 13:19
@Prab-27
Copy link
Contributor Author

Prab-27 commented Feb 19, 2026

@shahar1 it pass unit tests but system tests failed :

I tried in breeze container with pytest --system file but it will take some time - Related PR - here

I read this - here and tried to run it

I'm working on it and get back to you soon

if unwrap_single is None:
warnings.warn(
"Returning a list of Salesforce FileShare filenames from SalesforceToGcsOperator is deprecated and "
"will change to list[str] of GCS URIs in a future release. Set return_gcs_uris=True to opt in.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"will change to list[str] of GCS URIs in a future release. Set return_gcs_uris=True to opt in.",
"will change to list[str] of GCS URIs in a future release. Set unwrap_single=True to opt in.",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants