[v2-11-test] Add pool name validation to avoid XSS from the DAG file#61732
Merged
potiuk merged 1 commit intoapache:v2-11-testfrom Feb 11, 2026
Merged
[v2-11-test] Add pool name validation to avoid XSS from the DAG file#61732potiuk merged 1 commit intoapache:v2-11-testfrom
potiuk merged 1 commit intoapache:v2-11-testfrom
Conversation
Member
|
Can you please rebase it @molcay? We had some GitHub availability issues yesterday and this one will need rebase. |
Member
|
Actually - it passed all tests, so we can merge it. |
potiuk
approved these changes
Feb 11, 2026
potiuk
pushed a commit
that referenced
this pull request
Feb 16, 2026
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a validation for pool name for the operators.
An external researcher find the following XSS vulnerability in the composer-airflow repository.
Accepting the value of the pool name as a string without validation is causing the XSS vulnerability.
Users can inject a javascript file as a value to the pool argument and escalate their role as
Adminby targeting the Admin users.Sample DAG:
In this PR, I use the
validate_keymethod to validate thepoolargument and from now on, we will give a DAG import error if the value of thepoolargument is not valid.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.