Skip to content

fix(amazon): flush file buffer in S3Hook.download_file() before returning path #62078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 3 commits into from
Feb 17, 2026
+7 −6
Merged

fix(amazon): flush file buffer in S3Hook.download_file() before returning path #62078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7247b95
fix(amazon): flush file buffer in S3Hook.download_file() before retur…
filipposcotticom Feb 17, 2026
931499f
fix(amazon): use file-like mock in S3Hook.download_file() tests
filipposcotticom Feb 17, 2026
f1d7128
Merge branch 'main' into fix/s3hook-download-file-flush
pippo995 Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions providers/amazon/src/airflow/providers/amazon/aws/hooks/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1616,6 +1616,7 @@ def download_file(
ExtraArgs=extra_args,
Config=self.transfer_config,
)
file.flush()
get_hook_lineage_collector().add_input_asset(
context=self, scheme="s3", asset_kwargs={"bucket": bucket_name, "key": key}
)
Expand Down
12 changes: 6 additions & 6 deletions providers/amazon/tests/unit/amazon/aws/hooks/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1449,8 +1449,8 @@ def test_function_with_test_key(self, test_key, bucket_name=None):

@mock.patch("airflow.providers.amazon.aws.hooks.s3.NamedTemporaryFile")
def test_download_file(self, mock_temp_file, tmp_path):
path = tmp_path / "airflow_tmp_test_s3_hook"
mock_temp_file.return_value = path
mock_file = mock_temp_file.return_value
mock_file.name = str(tmp_path / "airflow_tmp_test_s3_hook")
s3_hook = S3Hook(aws_conn_id="s3_test", requester_pays=True)
s3_hook.check_for_key = Mock(return_value=True)
s3_obj = Mock()
Expand All @@ -1463,17 +1463,17 @@ def test_download_file(self, mock_temp_file, tmp_path):

s3_hook.get_key.assert_called_once_with(key, bucket)
s3_obj.download_fileobj.assert_called_once_with(
path,
mock_file,
Config=s3_hook.transfer_config,
ExtraArgs={"RequestPayer": "requester"},
)

assert path.name == output_file
assert mock_file.name == output_file

@mock.patch("airflow.providers.amazon.aws.hooks.s3.NamedTemporaryFile")
def test_download_file_exposes_lineage(self, mock_temp_file, tmp_path, hook_lineage_collector):
path = tmp_path / "airflow_tmp_test_s3_hook"
mock_temp_file.return_value = path
mock_file = mock_temp_file.return_value
mock_file.name = str(tmp_path / "airflow_tmp_test_s3_hook")
s3_hook = S3Hook(aws_conn_id="s3_test")
s3_hook.check_for_key = Mock(return_value=True)
s3_obj = Mock()
Expand Down