Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6209] Drop gcp_service_account_keys option #6768

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Dec 10, 2019

I wanna remove this option, because it is no longer supported by the Google Cloud Platform. The new
recommended service account keys management method for the GCP platform is
Workload Identity.

After merge, we should also add note in https://cwiki.apache.org/confluence/display/AIRFLOW/Managing+Per-task+Credentials+in+KubernetesExecutor


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6209
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the k8s label Dec 10, 2019
@mik-laj mik-laj requested a review from potiuk December 10, 2019 02:35
@codecov-io
Copy link

Codecov Report

Merging #6768 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6768      +/-   ##
==========================================
- Coverage   84.54%   84.26%   -0.29%     
==========================================
  Files         672      672              
  Lines       38081    38072       -9     
==========================================
- Hits        32197    32081     -116     
- Misses       5884     5991     +107
Impacted Files Coverage Δ
airflow/executors/kubernetes_executor.py 57.92% <ø> (-0.25%) ⬇️
airflow/kubernetes/pod_generator.py 95.27% <ø> (+0.61%) ⬆️
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
airflow/executors/sequential_executor.py 56% <0%> (-32%) ⬇️
airflow/utils/sqlalchemy.py 88.13% <0%> (-8.48%) ⬇️
airflow/utils/dag_processing.py 80.34% <0%> (-7.45%) ⬇️
airflow/executors/executor_loader.py 56.52% <0%> (-6.53%) ⬇️
airflow/jobs/scheduler_job.py 87.77% <0%> (-1.79%) ⬇️
airflow/hooks/dbapi_hook.py 89.83% <0%> (-1.7%) ⬇️
airflow/hooks/postgres_hook.py 92.95% <0%> (-1.41%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bebe8d...6f57bd8. Read the comment docs.

@dimberman dimberman self-requested a review December 10, 2019 22:04
@dimberman dimberman merged commit 53aa975 into apache:master Dec 10, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
* [AIRFLOW-6209] Drop gcp_service_account_keys option

* fixup! [AIRFLOW-6209] Drop gcp_service_account_keys option
@mik-laj mik-laj changed the title [AIRFLOW-6209] Drop gcp_service_account_keys option [AIRFLOW-6209] Drop gcp_service_account_key option May 27, 2020
@mik-laj mik-laj changed the title [AIRFLOW-6209] Drop gcp_service_account_key option [AIRFLOW-6209] Drop gcp_service_account_keys option May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants