Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6332] Extract logging options to new section #6887

Merged
merged 5 commits into from
Dec 25, 2019

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Dec 23, 2019

Currently [core] section in the configuration file is very long. It contains a lot of options, which makes configuration difficult. Other sections sometimes contain only 1 option. I propose to move the following options from the [core] section to the new [logging] section:

  • base_log_folder
  • remote_logging
  • remote_log_conn_id
  • remote_base_log_folder
  • encrypt_s3_logs
  • logging_level
  • fab_logging_level
  • logging_config_class
  • colored_console_log
  • colored_log_format
  • colored_formatter_class
  • log_format
  • simple_log_format
  • task_log_prefix_template
  • log_filename_template
  • log_processor_filename_template
  • dag_processor_manager_log_location
  • task_log_reader

This change is backwards compatible.

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6332
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

codecov-io commented Dec 24, 2019

Codecov Report

Merging #6887 into master will decrease coverage by 0.17%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6887      +/-   ##
==========================================
- Coverage   84.62%   84.45%   -0.18%     
==========================================
  Files         679      679              
  Lines       38497    38500       +3     
==========================================
- Hits        32579    32514      -65     
- Misses       5918     5986      +68
Impacted Files Coverage Δ
airflow/contrib/hooks/qubole_hook.py 52.67% <ø> (ø) ⬆️
airflow/cli/commands/celery_command.py 52.5% <ø> (ø) ⬆️
airflow/utils/log/gcs_task_handler.py 0% <0%> (ø) ⬆️
airflow/utils/log/wasb_task_handler.py 42.46% <0%> (ø) ⬆️
airflow/configuration.py 92.65% <100%> (+0.05%) ⬆️
airflow/settings.py 93.66% <100%> (ø) ⬆️
airflow/utils/dag_processing.py 80.95% <100%> (-7.05%) ⬇️
airflow/utils/serve_logs.py 100% <100%> (ø) ⬆️
...ib/utils/log/task_handler_with_custom_formatter.py 88.46% <100%> (ø) ⬆️
airflow/utils/log/s3_task_handler.py 98.5% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8734dfa...5a1c788. Read the comment docs.

@mik-laj mik-laj requested a review from turbaszek December 24, 2019 17:21
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@potiuk
Copy link
Member

potiuk commented Dec 25, 2019

Great that it's still backwards compatible :)

@potiuk potiuk merged commit 046b36f into apache:master Dec 25, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
* [AIRFLOW-6332] Extract logging options to new section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants