[fix] specify options various is class field;use ThreadLocal remove i…

…nstead of set null
apache · Oct 18, 2023 · 38d7529 · 38d7529
1 parent fee0af2
commit 38d7529
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/ams/server/src/main/java/com/netease/arctic/server/persistence/NestedSqlSession.java b/ams/server/src/main/java/com/netease/arctic/server/persistence/NestedSqlSession.java
@@ -75,7 +75,7 @@ public void close() {
     } else if (nestCount == 0 && sqlSession != null) {
       sqlSession.close();
       sqlSession = null;
-      sessions.set(null);
+      sessions.remove();
       nestCount = -1;
     }
   }

diff --git a/core/src/main/java/com/netease/arctic/optimizing/BaseOptimizingInput.java b/core/src/main/java/com/netease/arctic/optimizing/BaseOptimizingInput.java
@@ -34,7 +34,7 @@ public void option(String name, String value) {
 
   @Override
   public void options(Map<String, String> options) {
-    options.putAll(options);
+    this.options.putAll(options);
   }
 
   @Override

diff --git a/trino/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java b/trino/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
@@ -515,7 +515,7 @@ private void open() throws MetaException {
           LOG.info("Waiting " + retryDelaySeconds + " seconds before next connection attempt.");
           Thread.sleep(retryDelaySeconds * 1000);
         } catch (InterruptedException ignore) {
-          ignore.printStackTrace();
+          LOG.warn("Unexpected InterruptedException while waiting between connection retries.", ignore);
         }
       }
     }
@@ -2310,7 +2310,7 @@ public NotificationEventResponse getNextNotification(
       return rsp;
     } else {
       NotificationEventResponse filtered = new NotificationEventResponse();
-      if (rsp != null && rsp.getEvents() != null) {
+      if (rsp.getEvents() != null) {
         for (NotificationEvent e : rsp.getEvents()) {
           if (filter.accept(e)) {
             filtered.addToEvents(e);