Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support table filters to make AMS ignore tables that are not needed #1870

Closed
2 tasks done
Tracked by #1930
celltobig opened this issue Aug 22, 2023 · 3 comments · Fixed by #1879
Closed
2 tasks done
Tracked by #1930

[Feature]: Support table filters to make AMS ignore tables that are not needed #1870

celltobig opened this issue Aug 22, 2023 · 3 comments · Fixed by #1879
Labels
type:feature Feature Requests

Comments

@celltobig
Copy link
Contributor

Description

I want table filter , but now catalog database tables is full show

Use case/motivation

I want table filter , but now catalog database tables is full show,so add table filter

Describe the solution

add a table filter to list I want see the table

Subtasks

No response

Related issues

no

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@celltobig celltobig added the type:feature Feature Requests label Aug 22, 2023
@shidayang
Copy link
Contributor

Thanks for your bring up this feature. AFAIK, Currently, the list display of the table has a filter. What specifically do you mean by "filter" that you mentioned?
image

@wangtaohz
Copy link
Contributor

I think "table filter" here refers to ignoring some tables when loading tables from a catalog/database, rather than filtering on the WebUI. Maybe you can provide more information on how to implement it? @celltobig

And I think it's a common requirement. Looking forward to your PR. 😄

celltobig pushed a commit to celltobig/arctic that referenced this issue Aug 23, 2023
@wangtaohz
Copy link
Contributor

BTW, you could expand the title to help other developers better index this issue. @celltobig

@celltobig celltobig changed the title [Feature]: table filter [Feature]: Support table filters to make AMS ignore tables that are not needed Aug 24, 2023
zhoujinsong added a commit that referenced this issue Aug 31, 2023
…e not needed (#1879)

* [AMORO-1870]: table filter #1870 \n * add table filter

* fix check style

* fix gitignore

* fix db table filter

* fix table filter

* Update managing-catalogs.md and change docs

* fix checkstyle

* fix change table filter key

* change table filter md

* Update managing-catalogs.md

* Add Deprecated annotation

* Update docs/admin-guides/managing-catalogs.md

Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>

* Update ams/api/src/main/java/com/netease/arctic/ams/api/properties/CatalogMetaProperties.java

Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>

* fix check style

---------

Co-authored-by: 刘政 <zhengliu@gaojihealth.com>
Co-authored-by: wangtaohz <103108928+wangtaohz@users.noreply.github.com>
Co-authored-by: wangtao <wangtao3@corp.netease.com>
Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
@wangtaohz wangtaohz mentioned this issue Sep 7, 2023
56 tasks
ShawHee pushed a commit to ShawHee/arctic that referenced this issue Dec 29, 2023
…e not needed (apache#1879)

* [AMORO-1870]: table filter apache#1870 \n * add table filter

* fix check style

* fix gitignore

* fix db table filter

* fix table filter

* Update managing-catalogs.md and change docs

* fix checkstyle

* fix change table filter key

* change table filter md

* Update managing-catalogs.md

* Add Deprecated annotation

* Update docs/admin-guides/managing-catalogs.md

Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>

* Update ams/api/src/main/java/com/netease/arctic/ams/api/properties/CatalogMetaProperties.java

Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>

* fix check style

---------

Co-authored-by: 刘政 <zhengliu@gaojihealth.com>
Co-authored-by: wangtaohz <103108928+wangtaohz@users.noreply.github.com>
Co-authored-by: wangtao <wangtao3@corp.netease.com>
Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants