[ARCTIC-994] fix read legacy transaction id when MOR #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangtaohz
commented
Feb 6, 2023
| } | ||
|
|
||
| for (DataFile d : this.deleteFiles) { |
There was a problem hiding this comment.
I don't this this.deleteFiles should be handled here, so I remove these code
baiyangtx
approved these changes
Feb 7, 2023
github-actions
bot
added
module:ams-server
zhoujinsong
approved these changes
Feb 9, 2023
wangtaohz
added a commit
that referenced
this pull request
Feb 9, 2023
* if max-txId is not present, return null instead of -1 to be compatible with legacy txId * refactor and simplify OverwriteBaseFiles with transaction id * KeyedPartitionRewrite allow to set transactionId with a smaller value * refactor name to updateMaxTransactionIdDynamically * modify check this.dynamic != null (cherry picked from commit e88a0e5) Signed-off-by: wangtao <wangtao3@corp.netease.com>
This was referenced Apr 21, 2023
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
* if max-txId is not present, return null instead of -1 to be compatible with legacy txId * refactor and simplify OverwriteBaseFiles with transaction id * KeyedPartitionRewrite allow to set transactionId with a smaller value * refactor name to updateMaxTransactionIdDynamically * modify check this.dynamic != null
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
* if max-txId is not present, return null instead of -1 to be compatible with legacy txId * refactor and simplify OverwriteBaseFiles with transaction id * KeyedPartitionRewrite allow to set transactionId with a smaller value * refactor name to updateMaxTransactionIdDynamically * modify check this.dynamic != null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Now, the transaction ids of each partition are stored in the base table's property, and the legacy transaction id is supposed to be read when the transaction id is not present, in order to be compatible with the legacy tables from 0.3.*.
However, when the transaction id is not present, we return
-1, which is error-prone, and causes compatibility problem for MOR.Brief change log
nullinstead of-1when transaction id is not present.OverwriteBaseFileswhen handling transaction idKeyedPartitionRewriteto set the transaction id to a smaller valueHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation