[ARCTIC-1105][AMS] Fix snapshot expire and orphan clean misdelete the DataFiles #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the snapshot expire and the orphan file clean check valid files according to scan from metadata files
github-actions
bot
added
module:ams-server
added 2 commits
February 16, 2023 11:07
remove useless code
fix check style
wangtaohz
reviewed
Feb 16, 2023
ams/ams-server/src/main/java/com/netease/arctic/ams/server/utils/ContentFileUtil.java
Outdated
Show resolved
Hide resolved
|
The unit test cases for orphan files clean in We should add more test cases to ensure it meets our expectations. |
wangtaohz
reviewed
Feb 16, 2023
ams/ams-server/src/main/java/com/netease/arctic/ams/server/utils/HiveLocationUtils.java
Show resolved
Hide resolved
ams/ams-server/src/main/java/com/netease/arctic/ams/server/utils/ContentFileUtil.java
Show resolved
Hide resolved
fix code review
|
OK, I will add some unit test cases. |
wangtaohz
approved these changes
Feb 20, 2023
|
LGTM |
zhoujinsong
reviewed
Feb 21, 2023
| import org.apache.iceberg.PartitionSpec; | ||
| import org.apache.iceberg.Table; | ||
| import org.apache.iceberg.data.GenericRecord; |
There was a problem hiding this comment.
seems useless imports.
hzluting
pushed a commit
to hzluting/arctic
that referenced
this pull request
Mar 1, 2023
This was referenced Apr 21, 2023
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
… DataFiles (apache#1122) * apache#1105 the snapshot expire and the orphan file clean check valid files according to scan from metadata files * apache#1105 remove useless code * apache#1105 fix check style * apache#1105 fix code review * remove useless import --------- Co-authored-by: luting <dylzlt93299@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #1105
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation