[ARCTIC-930][AMS] Snapshot expire service should not expire snapshot with the lastest checkpoint id #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:ams-server
wangtaohz
changed the title
YesOrNo828
reviewed
Mar 1, 2023
There was a problem hiding this comment.
@wangtaohz Thanks for your contribution. I left some comments.
ams/ams-server/src/main/java/com/netease/arctic/ams/server/service/impl/TableExpireService.java
Outdated
Show resolved
Hide resolved
ams/ams-server/src/main/java/com/netease/arctic/ams/server/service/impl/TableExpireService.java
Outdated
Show resolved
Hide resolved
2.refactor method fetchLatestFlinkCommittedSnapshotTime
zhoujinsong
reviewed
Mar 2, 2023
ams/ams-server/src/main/java/com/netease/arctic/ams/server/service/impl/TableExpireService.java
Outdated
Show resolved
Hide resolved
ams/ams-server/src/main/java/com/netease/arctic/ams/server/service/impl/TableExpireService.java
Outdated
Show resolved
Hide resolved
ams/ams-server/src/main/java/com/netease/arctic/ams/server/service/impl/TableExpireService.java
Outdated
Show resolved
Hide resolved
ams/ams-server/src/main/java/com/netease/arctic/ams/server/service/impl/TableExpireService.java
Outdated
Show resolved
Hide resolved
ams/ams-server/src/main/java/com/netease/arctic/ams/server/service/impl/TableExpireService.java
Show resolved
Hide resolved
ams/ams-server/src/main/java/com/netease/arctic/ams/server/service/impl/TableExpireService.java
Outdated
Show resolved
Hide resolved
change to hiveLocations remove baseTable == null, changeTable == null change to baseExcludePaths add some comment for fetchLatestFlinkCommittedSnapshotTime import a static variable for flink.max-committed-checkpoint-id
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1178 +/- ##
============================================
- Coverage 27.86% 26.07% -1.79%
+ Complexity 4929 3787 -1142
============================================
Files 657 486 -171
Lines 69172 52944 -16228
Branches 7978 6128 -1850
============================================
- Hits 19275 13806 -5469
+ Misses 47986 37745 -10241
+ Partials 1911 1393 -518
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Apr 21, 2023
wangtaohz
added a commit
that referenced
this pull request
May 16, 2023
… not expire snapshot with the lastest checkpoint id (#1178) * the last snapshot with flink.max-committed-checkpoint-id should not be expired * 1.refactor TableExpireServicec for unit test 2.refactor method fetchLatestFlinkCommittedSnapshotTime * remove the use of traceId change to hiveLocations remove baseTable == null, changeTable == null change to baseExcludePaths add some comment for fetchLatestFlinkCommittedSnapshotTime import a static variable for flink.max-committed-checkpoint-id * add some comment for optimizer
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
…with the lastest checkpoint id (#1178) * the last snapshot with flink.max-committed-checkpoint-id should not be expired * 1.refactor TableExpireServicec for unit test 2.refactor method fetchLatestFlinkCommittedSnapshotTime * remove the use of traceId change to hiveLocations remove baseTable == null, changeTable == null change to baseExcludePaths add some comment for fetchLatestFlinkCommittedSnapshotTime import a static variable for flink.max-committed-checkpoint-id * add some comment for optimizer
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…with the lastest checkpoint id (apache#1178) * the last snapshot with flink.max-committed-checkpoint-id should not be expired * 1.refactor TableExpireServicec for unit test 2.refactor method fetchLatestFlinkCommittedSnapshotTime * remove the use of traceId change to hiveLocations remove baseTable == null, changeTable == null change to baseExcludePaths add some comment for fetchLatestFlinkCommittedSnapshotTime import a static variable for flink.max-committed-checkpoint-id * add some comment for optimizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
To fix #930
Brief change log
flink.max-committed-checkpoint-idshould not be expiredHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation