-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARCTIC-915][AMS] Orphan files clean service should not delete flink temporary metadata files #1181
Conversation
2.not delete flink temporary metadata file
refactor getExcludeFileNameRegex
...server/src/main/java/com/netease/arctic/ams/server/service/impl/OrphanFilesCleanService.java
Outdated
Show resolved
Hide resolved
...server/src/main/java/com/netease/arctic/ams/server/service/impl/OrphanFilesCleanService.java
Outdated
Show resolved
Hide resolved
modify logs of OrphanFilesCleanService use com.google.common.base.Strings#isNullOrEmpty
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
=============================================
- Coverage 52.78% 28.39% -24.39%
- Complexity 524 5020 +4496
=============================================
Files 43 658 +615
Lines 3704 69216 +65512
Branches 354 7981 +7627
=============================================
+ Hits 1955 19657 +17702
- Misses 1620 47631 +46011
- Partials 129 1928 +1799
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…uld not delete flink temporary metadata files (#1181) * 1.refactor OrphanFilesCleanService, remove useless execute/metadata flag 2.not delete flink temporary metadata file * fix checkstyle refactor getExcludeFileNameRegex * use io of UnkeyedTable instead of ArcticTable modify logs of OrphanFilesCleanService use com.google.common.base.Strings#isNullOrEmpty * introduce a static variable for flink.job-id * modify OrphanFilesCleanService test case * add test case for coverage * modify some logs for optimizer --------- Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
…temporary metadata files (#1181) * 1.refactor OrphanFilesCleanService, remove useless execute/metadata flag 2.not delete flink temporary metadata file * fix checkstyle refactor getExcludeFileNameRegex * use io of UnkeyedTable instead of ArcticTable modify logs of OrphanFilesCleanService use com.google.common.base.Strings#isNullOrEmpty * introduce a static variable for flink.job-id * modify OrphanFilesCleanService test case * add test case for coverage * modify some logs for optimizer --------- Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
…temporary metadata files (apache#1181) * 1.refactor OrphanFilesCleanService, remove useless execute/metadata flag 2.not delete flink temporary metadata file * fix checkstyle refactor getExcludeFileNameRegex * use io of UnkeyedTable instead of ArcticTable modify logs of OrphanFilesCleanService use com.google.common.base.Strings#isNullOrEmpty * introduce a static variable for flink.job-id * modify OrphanFilesCleanService test case * add test case for coverage * modify some logs for optimizer --------- Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
Why are the changes needed?
fix #915
Brief change log
flink.job-id
in the latest snapshot summaryOrphanFilesCleanService
, remove the useless execute/metadata/mode flagHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation