[ARCTIC-1190][AMS] Table expire service should not expire snapshot which optimizing planned with #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.refactor method fetchLatestFlinkCommittedSnapshotTime
change to hiveLocations remove baseTable == null, changeTable == null change to baseExcludePaths add some comment for fetchLatestFlinkCommittedSnapshotTime import a static variable for flink.max-committed-checkpoint-id
github-actions
bot
added
module:ams-server
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1193 +/- ##
============================================
+ Coverage 26.30% 26.44% +0.13%
- Complexity 3821 3839 +18
============================================
Files 486 486
Lines 52932 52956 +24
Branches 6130 6133 +3
============================================
+ Hits 13926 14006 +80
+ Misses 37597 37543 -54
+ Partials 1409 1407 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Apr 21, 2023
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
…ich optimizing planned with (#1193) * the last snapshot with flink.max-committed-checkpoint-id should not be expired * 1.refactor TableExpireServicec for unit test 2.refactor method fetchLatestFlinkCommittedSnapshotTime * remove the use of traceId change to hiveLocations remove baseTable == null, changeTable == null change to baseExcludePaths add some comment for fetchLatestFlinkCommittedSnapshotTime import a static variable for flink.max-committed-checkpoint-id * table expire should not expire snapshot for optimizing plan * add some comment for optimizer
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…ich optimizing planned with (apache#1193) * the last snapshot with flink.max-committed-checkpoint-id should not be expired * 1.refactor TableExpireServicec for unit test 2.refactor method fetchLatestFlinkCommittedSnapshotTime * remove the use of traceId change to hiveLocations remove baseTable == null, changeTable == null change to baseExcludePaths add some comment for fetchLatestFlinkCommittedSnapshotTime import a static variable for flink.max-committed-checkpoint-id * table expire should not expire snapshot for optimizing plan * add some comment for optimizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #1190
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation