[ARCTIC-1288][ams] limit the total files size bytes for Optimizing #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:ams-server
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1294 +/- ##
============================================
- Coverage 29.51% 29.51% -0.01%
- Complexity 5410 5414 +4
============================================
Files 695 695
Lines 71169 71178 +9
Branches 8185 8185
============================================
+ Hits 21008 21010 +2
- Misses 48147 48154 +7
Partials 2014 2014
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
zhoujinsong
reviewed
Apr 10, 2023
ams/ams-server/src/main/java/com/netease/arctic/ams/server/optimize/AbstractOptimizePlan.java
Outdated
Show resolved
Hide resolved
|
cherry-picked to 0.4.x |
This was referenced Apr 21, 2023
39 tasks
zhoujinsong
added a commit
that referenced
this pull request
May 31, 2023
…1294) * add self-optimizing.max-file-size-bytes * add test case * modify doc * refactor method name: reachOptimizeLimit --------- Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…pache#1294) * add self-optimizing.max-file-size-bytes * add test case * modify doc * refactor method name: reachOptimizeLimit --------- Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #1288
Brief change log
self-optimizing.max-file-size-byteswith default value 8 GBHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation