Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCTIC-1596][Flink]: turn on all unit tests annotated with @Ignore #1639

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

lklhdu
Copy link
Contributor

@lklhdu lklhdu commented Jul 3, 2023

Why are the changes needed?

fix #1596

Brief change log

  • remove @ignore in Flink module unit test
  • The flink 1.12, 1.14 and 1.15 versions are affected.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:mixed-flink Flink moduel for Mixed Format label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (70663c7) 48.23% compared to head (fa5d09c) 48.20%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1639      +/-   ##
============================================
- Coverage     48.23%   48.20%   -0.03%     
  Complexity     3533     3533              
============================================
  Files           463      463              
  Lines         24753    24753              
  Branches       2529     2529              
============================================
- Hits          11939    11933       -6     
- Misses        11714    11720       +6     
  Partials       1100     1100              
Flag Coverage Δ
core 48.11% <ø> (-0.03%) ⬇️
trino 48.64% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhoujinsong zhoujinsong merged commit 4167654 into apache:master Jul 3, 2023
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:mixed-flink Flink moduel for Mixed Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask][Flink]: turn on all unit tests annotated with @Ignore
2 participants