Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCTIC-1628][Feature][AMS]: Remove the Independent DeleteFiles for the Iceberg Format Table #1659

Merged
merged 3 commits into from
Jul 6, 2023
Merged

[ARCTIC-1628][Feature][AMS]: Remove the Independent DeleteFiles for the Iceberg Format Table #1659

merged 3 commits into from
Jul 6, 2023

Conversation

xujiangfeng001
Copy link
Contributor

Why are the changes needed?

This is to increase the feature to 0.4.x,for details, please refer to #1628.

Brief change log

Regularly delete iceberg independent deleteFiles by configuring 'clean-independent-delete-files.enabled'.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@github-actions github-actions bot added type:docs Improvements or additions to documentation module:core Core module module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.03 🎉

Comparison is base (252b39f) 31.04% compared to head (65ce915) 31.08%.

Additional details and impacted files
@@             Coverage Diff              @@
##              0.4.x    #1659      +/-   ##
============================================
+ Coverage     31.04%   31.08%   +0.03%     
- Complexity     5179     5188       +9     
============================================
  Files           674      674              
  Lines         62267    62315      +48     
  Branches       6958     6964       +6     
============================================
+ Hits          19332    19371      +39     
- Misses        41203    41210       +7     
- Partials       1732     1734       +2     
Flag Coverage Δ
core 29.71% <66.66%> (+0.03%) ⬆️
trino 52.76% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/com/netease/arctic/table/TableProperties.java 0.00% <ø> (ø)
...ease/arctic/ams/server/utils/UnKeyedTableUtil.java 66.00% <65.38%> (-0.67%) ⬇️
...s/server/service/impl/OrphanFilesCleanService.java 80.42% <68.18%> (-1.62%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wangtaohz
Copy link
Contributor

LGTM.
I can help to add some unit test cases from my local test, then we can merge it as soon as possible.

@xujiangfeng001
Copy link
Contributor Author

I can help to add some unit test cases from my local test, then we can merge it as soon as possible.

THX, this is really great.

@wangtaohz wangtaohz merged commit a8e5b60 into apache:0.4.x Jul 6, 2023
@xujiangfeng001 xujiangfeng001 deleted the delete-independentFiles branch August 1, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module module:core Core module type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants