-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support running ams in jdk17 environment. #1896
Conversation
Will these additional parameters fail to run due to unrecognized parameters under JDK 8? |
@baiyangtx no, I have also tested in jdk1.8 |
Thanks for your work! 👍 Here's another optimization for the
It would be better if we could fix it together. |
Thanks for your contributions, I concern if the command like '--add-options' can work in jdk-1.8, |
I test it locally in my local jdk8 environment, and it works well. |
I have deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you for submitting your Pull Request, your contribution is greatly appreciated!
@baiyangtx @wangtaohz @shidayang @zhoujinsong Thank you for your review! |
* support amoro ams in jdk17 * support ams in jdk17 * remove MAX_PERM_CONFIG --------- Co-authored-by: chenliang.lu <chenlianglu@tencent.com> Co-authored-by: baiyangtx <xiangnebula@163.com>
Why are the changes needed?
support running Amoro-ams in jdk17 environment.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation