-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-1335]Amoro AMS Support On K8S #1909
Conversation
7be5c15
to
340d678
Compare
Thank you for your contribution. Your PR is very valuable to Amoro community. Review request @baiyangtx bai @HuangFru |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good feature !
Thanks for your contribution, Your PR is very valuable to me. I will try this as soon as possible. |
5875687
to
9ceea0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it on Minikube. It's easy to install the AMS service using Helm. However, I don't think we should currently support multi-replica deployment for the following reasons:
-
Amoro is not a stateless service and caches a lot of state in memory. The current HA design is an active/standby architecture, and when the standby node becomes the master, the memory state needs to be reinitialized.
-
In the current design, the standby node has no accessible ports for Thrift or REST, so the pod liveness probe will have problems.
I suggest that we only support single-replica deployment in the first Helm version and support multi-replica deployment after resolving the pod liveness probe problems.
9ceea0d
to
03bbe0d
Compare
03bbe0d
to
2fa9bb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks a lot for your contribution!
I've tried this in Rancher Desktop with K8s on my local machine, works fine. |
* [AMORO-1335][helm-chart] Amoro k8s helm chart doc * [AMORO-1335][helm-chart] Amoro k8s helm chart yaml
Why are the changes needed?
AMS Run On K8S
Close #1335.
Brief change log
How was this patch tested?
Documentation