Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1335]Amoro AMS Support On K8S #1909

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

czy006
Copy link
Contributor

@czy006 czy006 commented Sep 3, 2023

Why are the changes needed?

AMS Run On K8S

Close #1335.

Brief change log

  • add helm chart for amoro
  • ams running on k8s

How was this patch tested?

  • ams log4j2 and config.xml can be rewrite
  • ams server and web ui on k8s open normal
  • Run test locally on k8s before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@majin1102
Copy link
Contributor

Thank you for your contribution. Your PR is very valuable to Amoro community.

Review request @baiyangtx bai @HuangFru

Copy link
Contributor

@Kyofin Kyofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature !

@baiyangtx
Copy link
Contributor

Thanks for your contribution, Your PR is very valuable to me. I will try this as soon as possible.

@czy006 czy006 force-pushed the issues/amoro-1335 branch 2 times, most recently from 5875687 to 9ceea0d Compare September 8, 2023 15:01
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on Minikube. It's easy to install the AMS service using Helm. However, I don't think we should currently support multi-replica deployment for the following reasons:

  1. Amoro is not a stateless service and caches a lot of state in memory. The current HA design is an active/standby architecture, and when the standby node becomes the master, the memory state needs to be reinitialized.

  2. In the current design, the standby node has no accessible ports for Thrift or REST, so the pod liveness probe will have problems.

I suggest that we only support single-replica deployment in the first Helm version and support multi-replica deployment after resolving the pod liveness probe problems.

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks a lot for your contribution!

@HuangFru
Copy link
Contributor

I've tried this in Rancher Desktop with K8s on my local machine, works fine.
LGTM. Thanks for your contribution!

@zhoujinsong zhoujinsong changed the title [Amoro-1335]Amoro AMS Support On K8S [AMORO-1335]Amoro AMS Support On K8S Sep 12, 2023
@zhoujinsong zhoujinsong merged commit b1ba50b into apache:master Sep 12, 2023
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
* [AMORO-1335][helm-chart] Amoro k8s helm chart doc

* [AMORO-1335][helm-chart] Amoro k8s helm chart yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support Kubernetes deployment for AMS
7 participants