Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Add basic configration of spotless #1926

Merged
merged 5 commits into from
Sep 7, 2023
Merged

[Improvement]: Add basic configration of spotless #1926

merged 5 commits into from
Sep 7, 2023

Conversation

baiyangtx
Copy link
Contributor

@baiyangtx baiyangtx commented Sep 6, 2023 •
edited
Loading

Why are the changes needed?

First step to solve the #1402.

Brief change log

  • Add global config of spotless-maven-plugin
  • Using googleJavaFormatter as java format style.
  • Remove some checkstyle rules conflict with googleJavaFormatter.
  • Replace spotless-maven-plugin with scalastyle-maven-plugin as scala code format checker

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)

@github-actions github-actions bot added module:mixed-spark Spark module for Mixed Format module:ams-server Ams server module type:infra type:build module:ams-dashboard Ams dashboard module labels Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023 •
edited
Loading

Codecov Report

Patch coverage is 62.83% of modified lines.

Files Changed Coverage
...g/apache/iceberg/parquet/AdaptHiveParquetUtil.java 61.80%
...e/iceberg/parquet/AdaptHiveParquetConversions.java 100.00%
...apache/iceberg/parquet/AdaptHiveParquetWriter.java 100.00%

📢 Thoughts on this report? Let us know!.

@baiyangtx baiyangtx marked this pull request as ready for review September 6, 2023 09:42
zhoujinsong
zhoujinsong approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baiyangtx baiyangtx requested a review from YesOrNo828 September 7, 2023 08:27
@wangtaohz wangtaohz mentioned this pull request Sep 7, 2023
Closed
56 tasks
YesOrNo828
YesOrNo828 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@YesOrNo828 YesOrNo828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baiyangtx baiyangtx merged commit f69c730 into apache:master Sep 7, 2023
@baiyangtx baiyangtx deleted the spotless-plugin branch September 12, 2023 01:41
@shidayang shidayang mentioned this pull request Oct 17, 2023
Closed
70 tasks
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
@baiyangtx @ShawHee
[Improvement]: Add basic configration of spotless && replace scala ch…
be3ed4d 
…eckstyle to spotless (apache#1926)

* add spotless to api module

* add spotless maven plugin/java config

* revert change of googleJavaFormatter

* use spotless as scala formatter checker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YesOrNo828 YesOrNo828 YesOrNo828 approved these changes

@zhoujinsong zhoujinsong zhoujinsong approved these changes

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module module:mixed-spark Spark module for Mixed Format type:build type:infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baiyangtx @YesOrNo828 @zhoujinsong