Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1924]Fix Iceberg tables undergoing major optimizing repeatedly #1976

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

celltobig
Copy link
Contributor

@celltobig celltobig commented Sep 13, 2023

Why are the changes needed?

fix full optimizing bug

close #1924

Brief change log

  • should not check major necessary and minor necessary if it's full optimizing

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes )
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Sep 13, 2023
@celltobig celltobig changed the title fix full FullOptimizing bug [AMORO-1924]fix full FullOptimizing bug Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
...rver/optimizing/plan/CommonPartitionEvaluator.java 100.00%

📢 Thoughts on this report? Let us know!.

@zhoujinsong zhoujinsong changed the title [AMORO-1924]fix full FullOptimizing bug [AMORO-1924]Fix Iceberg tables undergoing major optimizing repeatedly Sep 13, 2023
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks a lot for your contribution!

Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhoujinsong zhoujinsong merged commit 6da0068 into apache:master Sep 14, 2023
6 checks passed
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
…apache#1976)

fix full FullOptimizing bug

Co-authored-by: zhengliu <zhengliu@gaojihealth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MAJOR Optimizing is running repeatedly
3 participants