[AMORO-1985]Avoid NPE during disposing ArcticServiceContainer #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shidayang
reviewed
Sep 18, 2023
ams/server/src/main/java/com/netease/arctic/server/DefaultOptimizingService.java
Outdated
Show resolved
Hide resolved
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
baiyangtx
approved these changes
Sep 18, 2023
|
Could you please complete the 'Brief change log' above? For example: "add a nonnull check for 'optimizerMonitorTimer'" or something like this. |
ok |
HuangFru
approved these changes
Sep 18, 2023
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…#1986) * fix npe * replace Object.isNull() --------- Co-authored-by: yrf余若凡 <rfyu@trip.com> Co-authored-by: shidayang <530847445@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #1985 .
Brief change log
com.netease.arctic.server.DefaultOptimizingService#optimizerMonitorTimerHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation