Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1869] Avoid evaluating pending input during the optimization process #1997

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

XBaith
Copy link
Contributor

@XBaith XBaith commented Sep 19, 2023

Why are the changes needed?

Close #1869

Brief change log

  • Avoid SQL Transaction Timeouts

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@XBaith
Copy link
Contributor Author

XBaith commented Sep 19, 2023

cc @wangtaohz

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
...er/table/executor/TableRuntimeRefreshExecutor.java ø

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 👍

@wangtaohz
Copy link
Contributor

The downside is that the table cannot immediately transition from idle to pending after the optimizing is complete(failed/success), but I believe it is acceptable.

Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XBaith There are some useless import in this class causing check-style problem, pls remove it.

@wangtaohz wangtaohz merged commit d06367a into apache:master Sep 19, 2023
@XBaith XBaith deleted the fix-1869 branch September 19, 2023 09:57
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Failed to persist optimizing process records
2 participants