Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1877]Support display paimon Operations in 'operations' page #2079

Merged
merged 50 commits into from
Oct 13, 2023

Conversation

shidayang
Copy link
Contributor

Why are the changes needed?

Close #1877 .

Brief change log

Add DDLReverser class to reverse the ddl sql for iceberg and paimon

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…copy

# Conflicts:
#	ams/server/src/main/java/com/netease/arctic/server/table/executor/OrphanFilesCleaningExecutor.java
#	ams/server/src/main/java/com/netease/arctic/server/table/executor/SnapshotsExpiringExecutor.java
#	ams/server/src/test/java/com/netease/arctic/server/table/executor/TestSnapshotExpire.java
…copy

# Conflicts:
#	ams/server/src/main/java/com/netease/arctic/server/table/executor/OrphanFilesCleaningExecutor.java
…copy

# Conflicts:
#	ams/server/src/main/java/com/netease/arctic/server/catalog/MixedIcebergCatalogImpl.java
#	ams/server/src/main/java/com/netease/arctic/server/dashboard/ServerTableDescriptor.java
#	ams/server/src/main/java/com/netease/arctic/server/table/executor/OrphanFilesCleaningExecutor.java
#	ams/server/src/main/java/com/netease/arctic/server/table/executor/SnapshotsExpiringExecutor.java
#	ams/server/src/main/java/com/netease/arctic/server/table/executor/TableRuntimeRefreshExecutor.java
#	core/src/main/java/com/netease/arctic/formats/mixed/MixedHiveTable.java
@github-actions github-actions bot added module:core Core module module:ams-server Ams server module module:mixed-hive Hive moduel for Mixed Format type:build module:ams-dashboard Ams dashboard module labels Oct 11, 2023
# Conflicts:
#	ams/server/src/main/java/com/netease/arctic/server/dashboard/FormatTableDescriptor.java
#	ams/server/src/main/java/com/netease/arctic/server/dashboard/MixedAndIcebergTableDescriptor.java
#	ams/server/src/main/java/com/netease/arctic/server/dashboard/PaimonTableDescriptor.java
#	ams/server/src/main/java/com/netease/arctic/server/dashboard/ServerTableDescriptor.java
#	ams/server/src/test/java/com/netease/arctic/server/catalog/TableCatalogTestBase.java
#	ams/server/src/test/java/com/netease/arctic/server/dashboard/TestServerTableDescriptor.java
#	core/src/test/java/com/netease/arctic/formats/AmoroCatalogTestHelper.java
#	core/src/test/java/com/netease/arctic/formats/IcebergHadoopCatalogTestHelper.java
#	core/src/test/java/com/netease/arctic/formats/PaimonHadoopCatalogTestHelper.java
@github-actions github-actions bot removed module:ams-server Ams server module module:mixed-hive Hive moduel for Mixed Format type:build labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 180 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...rver/dashboard/MixedAndIcebergTableDescriptor.java 3.64% <100.00%> (-9.93%) ⬇️
...arctic/server/dashboard/PaimonTableDescriptor.java 58.33% <100.00%> (+33.33%) ⬆️
...c/server/dashboard/controller/TableController.java 4.46% <ø> (ø)
...netease/arctic/server/dashboard/model/DDLInfo.java 86.36% <100.00%> (+52.42%) ⬆️
...component/reverser/SparkMetadataChangeHandler.java 96.77% <96.77%> (ø)
...rver/dashboard/component/reverser/DDLReverser.java 92.00% <92.00%> (ø)
...dashboard/component/reverser/TableMetaExtract.java 74.19% <74.19%> (ø)
...ard/component/reverser/PaimonTableMetaExtract.java 64.44% <64.44%> (ø)
...rd/component/reverser/IcebergTableMetaExtract.java 54.38% <54.38%> (ø)
...ard/component/reverser/IcebergTypeToSparkType.java 15.15% <15.15%> (ø)
... and 1 more

... and 50 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@shidayang shidayang merged commit 2dd46f1 into apache:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask]: Support display paimon Operations in 'operations' page
3 participants