[Polish] Code polish #2105

GOODBOY008 · 2023-10-16T07:17:28Z

Polish code

GOODBOY008 · 2023-10-16T07:19:00Z

shidayang · 2023-10-16T07:27:20Z

@shidayang PTAL.

Thank you for your contribution. There are some formatting issues in the code that caused the CI to fail. Could you please fix them?

zhoujinsong

Thanks a lot for your contribution!

I noticed that you used the wrong indent configuration to format the code. You may need to reconfigure and reformat it.

zhoujinsong · 2023-10-16T09:15:53Z

ams/server/src/main/java/com/netease/arctic/server/catalog/InternalCatalog.java

-        .append('.')
-        .append(database)
-        .toString();
+    return name() +


The project use 2 spaces as indent and tab size, you may reconfigure it an reformat the codes here.

baiyangtx · 2023-10-16T09:47:08Z

What is the standard for this code specification? Are there any relevant checking tools to detect whether the code meets the standard?

Is this standardization of the code a one-time event or can it be continuously enforced? It seems like a one-time optimization, and there is no guarantee that subsequent submissions will meet the relevant constraints. Can checks be added in Github CI?

baiyangtx · 2023-10-16T09:48:54Z

The community is currently promoting another initiative to use the googleJavaFormatter + spotless plugin to format the code, please refer to this issue #1402. Is the goal of this PR consistent with that initiative?

codecov · 2023-10-17T08:21:46Z

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
...ic/optimizer/common/AbstractOptimizerOperator.java	`60.00% <100.00%> (+1.26%)`	⬆️
...ease/arctic/optimizer/common/OptimizerToucher.java	`80.39% <ø> (ø)`
...component/reverser/SparkMetadataChangeHandler.java	`96.77% <ø> (ø)`
...shboard/controller/PlatformFileInfoController.java	`16.66% <ø> (ø)`
...ease/arctic/server/dashboard/model/SqlExample.java	`0.00% <ø> (ø)`
...tease/arctic/server/dashboard/model/SqlStatus.java	`0.00% <ø> (ø)`
...tease/arctic/server/dashboard/model/TableMeta.java	`0.00% <ø> (ø)`
...ic/server/exception/IllegalTaskStateException.java	`0.00% <ø> (ø)`
...ic/server/exception/OptimizingClosedException.java	`0.00% <ø> (ø)`
...arctic/server/exception/TaskNotFoundException.java	`0.00% <ø> (ø)`
... and 66 more

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

GOODBOY008 · 2023-10-18T09:04:38Z

@zhoujinsong @shidayang @baiyangtx PTAL , Thank you~

shidayang · 2023-10-18T09:20:23Z

LGTM

zhoujinsong

Thanks a lot for your contribution!

...izer/common/src/main/java/com/netease/arctic/optimizer/common/AbstractOptimizerOperator.java

core/src/test/java/com/netease/arctic/utils/map/TestStructLikeMap.java

baiyangtx · 2023-10-18T11:15:38Z

hive/src/main/java/com/netease/arctic/hive/HMSClient.java

  void alterPartition(String dbName, String tblName, Partition newPart, EnvironmentContext environmentContext)
-      throws InvalidOperationException, MetaException, TException, ClassNotFoundException,
+      throws TException, ClassNotFoundException,
      NoSuchMethodException, InvocationTargetException, IllegalAccessException;

  Partition getPartition(String dbName, String tblName,
-                         List<String> partVals) throws NoSuchObjectException, MetaException, TException;
+                         List<String> partVals) throws TException;

  Partition getPartition(String dbName, String tblName,
-                         String name) throws MetaException, UnknownTableException, NoSuchObjectException, TException;
+                         String name) throws TException;

-  Table getTable(String dbName, String tableName) throws MetaException,
-      TException, NoSuchObjectException;
+  Table getTable(String dbName, String tableName) throws
+      TException;

  void alterTable(String defaultDatabaseName, String tblName,
-                  Table table) throws InvalidOperationException, MetaException, TException;
+                  Table table) throws TException;

  List<Partition> listPartitions(String dbName, String tblName,
-                                 short maxParts) throws NoSuchObjectException, MetaException, TException;
+                                 short maxParts) throws TException;

  List<Partition> listPartitions(String dbName, String tblName,
                                 List<String> partVals, short maxParts)
-      throws NoSuchObjectException, MetaException, TException;
+      throws TException;

  List<String> listPartitionNames(String dbName, String tblName,
-                                  short maxParts) throws MetaException, TException;
+                                  short maxParts) throws TException;


  void createDatabase(Database db)
-      throws InvalidObjectException, AlreadyExistsException, MetaException, TException;
+      throws TException;

  void dropDatabase(String name, boolean deleteData, boolean ignoreUnknownDb, boolean cascade)
-      throws NoSuchObjectException, InvalidOperationException, MetaException, TException;
+      throws TException;

  void dropTable(String dbname, String tableName, boolean deleteData,
-                 boolean ignoreUnknownTab) throws MetaException, TException,
-      NoSuchObjectException;
+                 boolean ignoreUnknownTab) throws TException;

-  void createTable(Table tbl) throws AlreadyExistsException,
-      InvalidObjectException, MetaException, NoSuchObjectException, TException;
+  void createTable(Table tbl) throws
+      TException;

  Database getDatabase(String databaseName)
-      throws NoSuchObjectException, MetaException, TException;
+      throws TException;

  Partition addPartition(Partition partition)
-      throws InvalidObjectException, AlreadyExistsException, MetaException, TException;
+      throws TException;

  boolean dropPartition(String dbName, String tblName, List<String> partVals,
                        PartitionDropOptions options) throws TException;

  int addPartitions(List<Partition> partitions)
-      throws InvalidObjectException, AlreadyExistsException, MetaException, TException;
+      throws TException;


-  List<String> getAllTables(String dbName) throws MetaException, TException, UnknownDBException;
+  List<String> getAllTables(String dbName) throws TException;


It makes sense to throw more semantically clear exceptions in an interface.

zhoujinsong

LGTM!
Thanks a lot for your great work!

* exclude flink * fix ci * fix ci * test ci * test ci * polish flink 1.15 * add polish code * Address comment * Address comment

zhoujinsong reviewed Oct 16, 2023

View reviewed changes

GOODBOY008 force-pushed the master-polish branch from 1a81794 to 3009681 Compare October 17, 2023 08:08

GOODBOY008 force-pushed the master-polish branch 2 times, most recently from e8837c7 to 566de76 Compare October 18, 2023 07:40

GOODBOY008 requested a review from zhoujinsong October 18, 2023 09:03

shidayang approved these changes Oct 18, 2023

View reviewed changes

GOODBOY008 force-pushed the master-polish branch from 566de76 to 365e62f Compare October 18, 2023 09:55

zhoujinsong reviewed Oct 18, 2023

View reviewed changes

...izer/common/src/main/java/com/netease/arctic/optimizer/common/AbstractOptimizerOperator.java Outdated Show resolved Hide resolved

baiyangtx reviewed Oct 18, 2023

View reviewed changes

GOODBOY008 and others added 7 commits October 18, 2023 22:39

exclude flink

80c2b8f

fix ci

54525c7

fix ci

66f76cc

test ci

036f4bf

test ci

ae3d4dc

polish flink 1.15

d347140

add polish code

988f7a3

GOODBOY008 force-pushed the master-polish branch from 365e62f to 988f7a3 Compare October 18, 2023 14:39

GOODBOY008 added 2 commits October 19, 2023 10:21

Address comment

82e56ee

Address comment

8da185a

zhoujinsong approved these changes Oct 19, 2023

View reviewed changes

zhoujinsong merged commit 86cf5c7 into apache:master Oct 19, 2023

shidayang mentioned this pull request Oct 24, 2023

Release-0.6.0 roadmap #1847

Closed

70 tasks

GOODBOY008 deleted the master-polish branch October 24, 2023 06:21

ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023

[Polish] Code polish (apache#2105)

baadbb8

* exclude flink * fix ci * fix ci * test ci * test ci * polish flink 1.15 * add polish code * Address comment * Address comment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Polish] Code polish #2105

[Polish] Code polish #2105

GOODBOY008 commented Oct 16, 2023

GOODBOY008 commented Oct 16, 2023

shidayang commented Oct 16, 2023

zhoujinsong left a comment

zhoujinsong Oct 16, 2023

baiyangtx commented Oct 16, 2023

baiyangtx commented Oct 16, 2023

codecov bot commented Oct 17, 2023 •

edited

Loading

GOODBOY008 commented Oct 18, 2023

shidayang commented Oct 18, 2023

zhoujinsong left a comment

baiyangtx Oct 18, 2023

zhoujinsong left a comment

[Polish] Code polish #2105

[Polish] Code polish #2105

Conversation

GOODBOY008 commented Oct 16, 2023

GOODBOY008 commented Oct 16, 2023

shidayang commented Oct 16, 2023

zhoujinsong left a comment

Choose a reason for hiding this comment

zhoujinsong Oct 16, 2023

Choose a reason for hiding this comment

baiyangtx commented Oct 16, 2023

baiyangtx commented Oct 16, 2023

codecov bot commented Oct 17, 2023 • edited Loading

Codecov Report

GOODBOY008 commented Oct 18, 2023

shidayang commented Oct 18, 2023

zhoujinsong left a comment

Choose a reason for hiding this comment

baiyangtx Oct 18, 2023

Choose a reason for hiding this comment

zhoujinsong left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 17, 2023 •

edited

Loading