Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1878] Paimon support Optimizing info #2130

Merged
merged 14 commits into from
Oct 20, 2023

Conversation

HuangFru
Copy link
Contributor

@HuangFru HuangFru commented Oct 17, 2023

Why are the changes needed?

Close #1878.

Brief change log

  • Add Paimon's way to get compaction info in TableContriller.
  • Implement Paimon's way to get compaction info in ServerTableDescriptor.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Oct 17, 2023
@HuangFru
Copy link
Contributor Author

This is the screenshot:
image

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...c/server/dashboard/controller/TableController.java 4.25% <0.00%> (ø)
...arctic/server/dashboard/ServerTableDescriptor.java 16.21% <2.50%> (ø)

... and 452 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@shidayang
Copy link
Contributor

This is the screenshot: image

Standardizing the presentation format of null values.

@HuangFru
Copy link
Contributor Author

This is the screenshot: image

Standardizing the presentation format of null values.

image
Updated.

@shidayang shidayang merged commit 5a0dabe into apache:master Oct 20, 2023
5 of 6 checks passed
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask]: Support display paimon optimizing information in optimizing page
3 participants