[Improvement]: Add TableFormat information to the return value of the Catalog listTable method. #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:core
# Conflicts: # ams/server/src/main/java/com/netease/arctic/server/table/DefaultTableService.java
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
zhoujinsong
reviewed
Oct 19, 2023
| @@ -21,16 +21,16 @@ | |||
| import com.netease.arctic.ams.api.TableFormat; | |||
| import com.netease.arctic.table.TableIdentifier; | |||
|
|
|||
| public class TableMeta { | |||
| public class TableIDWithFormat { | |||
There was a problem hiding this comment.
How about TableIDAndFormat?
ams/server/src/main/java/com/netease/arctic/server/table/TableManager.java
Outdated
Show resolved
Hide resolved
shidayang
reviewed
Oct 20, 2023
core/src/test/java/com/netease/arctic/formats/AmoroCatalogTestHelper.java
Outdated
Show resolved
Hide resolved
wangtaohz
reviewed
Oct 20, 2023
ams/server/src/main/java/com/netease/arctic/server/persistence/mapper/TableMetaMapper.java
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/dashboard/controller/TableController.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/table/ServerTableIdentifier.java
Show resolved
Hide resolved
# Conflicts: # ams/server/src/main/java/com/netease/arctic/server/dashboard/ServerTableDescriptor.java # ams/server/src/main/java/com/netease/arctic/server/dashboard/controller/TableController.java
shidayang
approved these changes
Oct 23, 2023
|
LGTM |
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
… Catalog listTable method. (apache#2150) * ServerCatalog listTable return TableIDWithFormat * ServerCatalog listTable return TableIDWithFormat * fix checkstyle in ams/server * fix checkstyles * remove table_format from table_runtime * fix checkstyle. * fix reviewers * fix compile error * fix compile * fix compile * remove useless code * fix checkstyle * unit test passed. * fix merge errors * fix ResultMap for ServerTableIdentifier * remove table format in table_metadata. * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This PR is part of this issue #1061 .
In order for a catalog to support multiple formats, we need to include
TableFormatinformation in the return value of the catalog's listTable interface. The code changes related to the #1061 are very large. To reduce the burden of review, some code refactoring has been proposed as a separate PR.Brief change log
listTablefromList<TableIdentifier>toList<TableIDWithFormat>formattoServerTableIdentifierformatfromtable_runtimeServerTableDescriptorfromServerTableIdentifiertoTableIdentifier.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation