[hotfix] Fix deleting Puffin files when cleaning orphan files #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2320 +/- ##
============================================
- Coverage 52.94% 52.70% -0.25%
- Complexity 3612 4207 +595
============================================
Files 465 511 +46
Lines 24502 29275 +4773
Branches 2340 2859 +519
============================================
+ Hits 12973 15428 +2455
- Misses 10510 12594 +2084
- Partials 1019 1253 +234
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shidayang
reviewed
Nov 17, 2023
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Outdated
Show resolved
Hide resolved
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…#2320) * fix orphan files deleting puffin files * using Sets.union instead of ImmutableSet Builder * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The puffin files are in the
data/puffinlocation which should also be protected when cleaning the data files.Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation