[AMORO-2336] Set the renew blocker thread to be a daemon thread #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2337 +/- ##
============================================
- Coverage 52.78% 51.14% -1.64%
+ Complexity 4222 591 -3631
============================================
Files 511 46 -465
Lines 29345 4761 -24584
Branches 2857 520 -2337
============================================
- Hits 15489 2435 -13054
+ Misses 12606 2092 -10514
+ Partials 1250 234 -1016
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wangtaohz
added a commit
that referenced
this pull request
Nov 20, 2023
renew blocker thread should be daemon
wangtaohz
added a commit
that referenced
this pull request
Nov 20, 2023
renew blocker thread should be daemon
|
I have cherry-picked to 0.5.x and 0.6.x. |
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…he#2337) renew blocker thread should be daemon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2336 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation