Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2316] The Files page supports filtering by partition name and sorting by dictionary value #2343

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

shendanfengg
Copy link
Contributor

@shendanfengg shendanfengg commented Nov 21, 2023

Why are the changes needed?

This is the backend implementation of #2316 .

Brief change log

  • Sort by partition name and add keywords filter

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5436d1e) 52.69% compared to head (a102916) 52.65%.
Report is 2 commits behind head on master.

Files Patch % Lines
...c/server/dashboard/controller/TableController.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2343      +/-   ##
============================================
- Coverage     52.69%   52.65%   -0.05%     
+ Complexity     4219     4216       -3     
============================================
  Files           511      511              
  Lines         29329    29346      +17     
  Branches       2851     2853       +2     
============================================
- Hits          15454    15451       -3     
- Misses        12630    12647      +17     
- Partials       1245     1248       +3     
Flag Coverage Δ
core 52.99% <0.00%> (-0.03%) ⬇️
trino 50.87% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HuangFru HuangFru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that lost frontend code?

@shendanfengg
Copy link
Contributor Author

Seems that lost frontend code?

The front-end code needs to be provided by another pr

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shendanfengg
❌ shendanfeng


shendanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks a lot for you contribution.

@zhoujinsong
Copy link
Contributor

Issue #2316 seems can not be closed yet cause the dashboard has not supported the filter feature.

@zhoujinsong zhoujinsong merged commit 7ca488d into apache:master Nov 29, 2023
4 of 7 checks passed
@wangtaohz wangtaohz deleted the fix-2316 branch December 4, 2023 08:53
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
…sorting by dictionary value (apache#2343)

* fix-2316

* fix-2316

* change param name

---------

Co-authored-by: shendanfeng <shendanfeng01@corp.netease.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants