[AMORO-2359] Support log out of the ams dashboard #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2360 +/- ##
=========================================
Coverage 52.94% 52.95%
- Complexity 4308 4310 +2
=========================================
Files 516 516
Lines 29799 29803 +4
Branches 2901 2901
=========================================
+ Hits 15778 15783 +5
Misses 12741 12741
+ Partials 1280 1279 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
A very useful feature and thanks for you contribution! 👍 cc @Aireed |
shidayang
reviewed
Nov 27, 2023
ams/server/src/main/java/com/netease/arctic/server/dashboard/controller/LoginController.java
Outdated
Show resolved
Hide resolved
shidayang
approved these changes
Nov 30, 2023
|
I have resolved conflicts, please review it again. @shidayang @wangtaohz |
wangtaohz
approved these changes
Dec 1, 2023
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
* [AMORO-2359] Support log out of the ams dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #2359.
Screenshot as follows:
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation