-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMORO-2453] Fix multiple schedule tasks #2458
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2458 +/- ##
============================================
- Coverage 52.95% 52.94% -0.01%
+ Complexity 4419 4416 -3
============================================
Files 534 534
Lines 30554 30565 +11
Branches 2991 2992 +1
============================================
+ Hits 16179 16182 +3
- Misses 13078 13090 +12
+ Partials 1297 1293 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HuangFru I left some comments, please take a look.
ams/server/src/main/java/com/netease/arctic/server/table/executor/BaseTableExecutor.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/table/executor/BaseTableExecutor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* fix multi schedule * fix comment * revert front end * revert front end * revert and commit * revert and commit * revert front end * revert front end * fix atomicity
Why are the changes needed?
Close #2453.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation