Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2453] Fix multiple schedule tasks #2458

Merged
merged 10 commits into from
Dec 25, 2023

Conversation

HuangFru
Copy link
Contributor

Why are the changes needed?

Close #2453.

Brief change log

  • Use a concurrent map to insure one table to one schedule task.
  • Use scheduleWithFixedDelay instead of finally scheduling another task.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Dec 21, 2023
@HuangFru HuangFru requested a review from wangtaohz December 21, 2023 03:01
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (39b6c13) 52.95% compared to head (e3020ad) 52.94%.
Report is 5 commits behind head on master.

Files Patch % Lines
...rctic/server/table/executor/BaseTableExecutor.java 30.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2458      +/-   ##
============================================
- Coverage     52.95%   52.94%   -0.01%     
+ Complexity     4419     4416       -3     
============================================
  Files           534      534              
  Lines         30554    30565      +11     
  Branches       2991     2992       +1     
============================================
+ Hits          16179    16182       +3     
- Misses        13078    13090      +12     
+ Partials       1297     1293       -4     
Flag Coverage Δ
core 53.32% <30.00%> (+0.03%) ⬆️
trino 50.87% <ø> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HuangFru I left some comments, please take a look.

@HuangFru HuangFru marked this pull request as draft December 21, 2023 10:49
@HuangFru HuangFru marked this pull request as ready for review December 21, 2023 11:18
Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 56a5f5f into apache:master Dec 25, 2023
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
* fix multi schedule

* fix comment

* revert front end

* revert front end

* revert and commit

* revert and commit

* revert front end

* revert front end

* fix atomicity
@zhoujinsong zhoujinsong mentioned this pull request Jun 25, 2024
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Periodic snapshots expiring tasks will be scheduled redundantly
3 participants