Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2464] Fix bug AMS will repeat trigger the same minor optimize when the bucket > self-optimizing.minor.trigger.file-count #2465

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

GavinH1984
Copy link
Contributor

Why are the changes needed?

Close #2464 .

Brief change log

  • correct the logic of checking the minor optimze tirgger conditions.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…r optimize when the bucket > self-optimizing.minor.trigger.file-count
@CLAassistant
Copy link

CLAassistant commented Dec 21, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Dec 21, 2023
@GavinH1984 GavinH1984 changed the title [Amoro-2464] Fix bug [Amoro-2464] Fix bug AMS will repeat trigger the same minor optimize when the bucket > self-optimizing.minor.trigger.file-count Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14403fc) 52.85% compared to head (30cbe94) 52.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2465      +/-   ##
============================================
+ Coverage     52.85%   52.95%   +0.10%     
- Complexity     4411     4419       +8     
============================================
  Files           534      534              
  Lines         30559    30559              
  Branches       2991     2991              
============================================
+ Hits          16152    16184      +32     
+ Misses        13126    13082      -44     
- Partials       1281     1293      +12     
Flag Coverage Δ
core 53.31% <100.00%> (+0.01%) ⬆️
trino 50.99% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wangtaohz wangtaohz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujinsong zhoujinsong changed the title [Amoro-2464] Fix bug AMS will repeat trigger the same minor optimize when the bucket > self-optimizing.minor.trigger.file-count [AMORO-2464] Fix bug AMS will repeat trigger the same minor optimize when the bucket > self-optimizing.minor.trigger.file-count Dec 22, 2023
@zhoujinsong zhoujinsong merged commit 8facf5b into apache:master Dec 22, 2023
7 checks passed
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
…when the bucket > self-optimizing.minor.trigger.file-count (apache#2465)

Fix the bug: apache#2464  [Bug]: AMS will repeat trigger the same minor optimize when the bucket > self-optimizing.minor.trigger.file-count
@GavinH1984 GavinH1984 deleted the fix-2464 branch December 31, 2023 10:37
zhoujinsong pushed a commit that referenced this pull request Feb 2, 2024
…when the bucket > self-optimizing.minor.trigger.file-count (#2465)

Fix the bug: #2464  [Bug]: AMS will repeat trigger the same minor optimize when the bucket > self-optimizing.minor.trigger.file-count

(cherry picked from commit 8facf5b)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@zhoujinsong zhoujinsong mentioned this pull request Feb 2, 2024
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
4 participants