Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2546] Upgrade paimon dependency to 0.7.0 #2548

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

huyuanfeng2018
Copy link
Contributor

Why are the changes needed?

Close #2546.

Brief change log

  • Bump Paimon 0.5.0 to 0.7.0

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zhoujinsong
❌ huyuanfeng


huyuanfeng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9c397f8) 32.24% compared to head (89acbe9) 32.23%.
Report is 1 commits behind head on master.

Files Patch % Lines
...arctic/server/dashboard/PaimonTableDescriptor.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2548      +/-   ##
============================================
- Coverage     32.24%   32.23%   -0.01%     
- Complexity     4384     4385       +1     
============================================
  Files           589      589              
  Lines         49888    49892       +4     
  Branches       6618     6618              
============================================
- Hits          16084    16081       -3     
- Misses        32533    32538       +5     
- Partials       1271     1273       +2     
Flag Coverage Δ
core 30.28% <0.00%> (-0.01%) ⬇️
trino 50.93% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baiyangtx
Copy link
Contributor

The CI is failed. @huyuanfeng2018

@huyuanfeng2018
Copy link
Contributor Author

huyuanfeng2018 commented Feb 19, 2024

This is caused by a bug in hive. The version we are using is 2.1.1, and this bug exists https://issues.apache.org/jira/browse/HIVE-15081?jql=project%20%3D%20HIVE

Need to consider upgrading hive dependencies to 2.3.9?
@baiyangtx cc

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit c2bdb64 into apache:master Feb 20, 2024
4 of 7 checks passed
@huyuanfeng2018 huyuanfeng2018 deleted the amoro_2546 branch February 20, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Upgrade paimon dependency to 0.7.0
4 participants