Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2555] When expiring historic data,the latest snapshot generate… #2557

Closed
wants to merge 1 commit into from

Conversation

rfyu
Copy link
Contributor

@rfyu rfyu commented Feb 20, 2024

…d by amoro should not be used

Why are the changes needed?

Close #2555.

Brief change log

  • When expiring historic data,the latest snapshot generated by amoro should not be used

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


yrf余若凡 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the module:ams-server Ams server module label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c2bdb64) 32.23% compared to head (a01270e) 32.23%.

Files Patch % Lines
...com/netease/arctic/ams/api/CommitMetaProducer.java 0.00% 4 Missing ⚠️
.../optimizing/maintainer/IcebergTableMaintainer.java 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2557      +/-   ##
============================================
- Coverage     32.23%   32.23%   -0.01%     
  Complexity     4383     4383              
============================================
  Files           589      589              
  Lines         49892    49897       +5     
  Branches       6618     6619       +1     
============================================
+ Hits          16081    16082       +1     
- Misses        32539    32542       +3     
- Partials       1272     1273       +1     
Flag Coverage Δ
core 30.28% <20.00%> (-0.01%) ⬇️
trino 50.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rfyu rfyu closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: When expiring historic data,the latest snapshot generated by amoro should not be used
2 participants