Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2607]'Last Commit Time' for Paimon partition table in File pages has wrong zone #2608

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

xieyi888
Copy link
Contributor

@xieyi888 xieyi888 commented Mar 8, 2024

Why are the changes needed?

Close #2607.

Brief change log

  • Fix: 'Last Commit Time' for Paimon partition table in File pages has wrong zone

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate
    for partition updatae_day=2024-03-08 'Last Commit Time' is '2024-03-08 18:24:03' on dashboard as below
    image

update time is also '2024-03-08 18:24' in hdfs filesystem

image

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 32.08%. Comparing base (61a6e97) to head (4c17487).

Files Patch % Lines
...arctic/server/dashboard/PaimonTableDescriptor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2608      +/-   ##
============================================
- Coverage     32.13%   32.08%   -0.05%     
+ Complexity     4412     4408       -4     
============================================
  Files           605      605              
  Lines         50596    50596              
  Branches       6655     6655              
============================================
- Hits          16258    16235      -23     
- Misses        33061    33096      +35     
+ Partials       1277     1265      -12     
Flag Coverage Δ
core 30.21% <0.00%> (ø)
trino 50.38% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baiyangtx baiyangtx merged commit 3f67bb5 into apache:master Mar 12, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:'Last Commit Time' for Paimon partition table in File pages has wrong zone
3 participants