Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-2698] Display more details in the page of Optimizing->Optimizers #2699

Merged
merged 6 commits into from
Apr 20, 2024
Merged

[AMORO-2698] Display more details in the page of Optimizing->Optimizers #2699

merged 6 commits into from
Apr 20, 2024

Conversation

tcodehuber
Copy link
Contributor

Why are the changes needed?

Close #2698.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Apr 2, 2024
@tcodehuber tcodehuber requested a review from zhoujinsong April 3, 2024 03:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.98%. Comparing base (882b78b) to head (e68b49c).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2699      +/-   ##
============================================
- Coverage     34.02%   33.98%   -0.04%     
+ Complexity     4364     4362       -2     
============================================
  Files           604      604              
  Lines         50754    50754              
  Branches       6673     6673              
============================================
- Hits          17269    17249      -20     
- Misses        32086    32116      +30     
+ Partials       1399     1389      -10     
Flag Coverage Δ
core 32.29% <ø> (ø)
trino 50.50% <ø> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcodehuber tcodehuber merged commit f4cc0a5 into apache:master Apr 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Display more details in the page of Optimizing->Optimizers
4 participants