Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO2795][helm chart] add variables and descriptions into values.yaml #2799

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

lianneli
Copy link
Contributor

@lianneli lianneli commented Apr 29, 2024

Why are the changes needed?

Fix #2795

Brief change log

  • Add variables existed in templates but not in Values.yaml. Those variables are: nameOverride, commonLabels and commonAnnotations.
  • Change Values.yaml: add more descriptions, refs and modify the file with standard format which seems more pretty.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

test with unittest(#2794)
This change is not dependency by #2794 , Just use it as test.
image

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? none

@lianneli
Copy link
Contributor Author

@baiyangtx Another pr, Could you please help to review? Thanks.

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contributions

@baiyangtx baiyangtx merged commit 802fa2d into apache:master Apr 29, 2024
1 check passed
@lianneli lianneli deleted the master-fixissue2795 branch April 30, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Add some Variables and Descriptions which exist in templates but not in Values.yaml
2 participants