Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3194]improvement: optimize plan log print #3212

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Aireed
Copy link
Contributor

@Aireed Aireed commented Sep 20, 2024

Why are the changes needed?

Close #3194.

Brief change log

  • Only print the table ID, not the full table name.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Sep 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.78%. Comparing base (8207efc) to head (fa3aeb5).
Report is 27 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3212      +/-   ##
============================================
+ Coverage     29.43%   29.78%   +0.35%     
- Complexity     3685     3755      +70     
============================================
  Files           568      573       +5     
  Lines         47267    47730     +463     
  Branches       6196     6202       +6     
============================================
+ Hits          13912    14217     +305     
- Misses        32372    32522     +150     
- Partials        983      991       +8     
Flag Coverage Δ
core 29.78% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aireed Aireed merged commit 7081bbc into apache:master Sep 20, 2024
4 checks passed
zhoujinsong pushed a commit that referenced this pull request Oct 11, 2024
improvement: optimize log print

Co-authored-by: 王涛 <wangtao@HIH-L-10114.local>
(cherry picked from commit 7081bbc)
Signed-off-by: zhoujinsong <zhoujinsong0505@163.com>
@klion26 klion26 mentioned this pull request Nov 19, 2024
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
3 participants