[AMORO-3258] Use SimpleFuture to refactor TaskRuntime and eliminate t… #3259
Conversation
| lock.lock(); | ||
| try { | ||
| return taskQueue.poll(); | ||
| return status != Status.CLOSED || status != Status.FAILED ? taskQueue.poll() : null; |
There was a problem hiding this comment.
status != Status.CLOSED && status != Status.FAILED
?
There was a problem hiding this comment.
I have fixed this. TBR
majin1102
force-pushed
the
process-dev
branch
from
b9e04f3 to
ad9ea59
Compare
majin1102
force-pushed
the
process-dev
branch
from
9d48ea2 to
ff28b7f
Compare
|
@majin1102 There seem to be some test failures that need to be fixed. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@amoro.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
…ask lock
Why are the changes needed?
Close #3258 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation