[AMORO-3279] Get the total result when retrieve the optimizing tables from db #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klion26
force-pushed
the
3279-imporve-with-pagehelper
branch
2 times, most recently
from
828f397 to
9adff28
Compare
klion26
commented
Oct 21, 2024
...ams/src/main/java/org/apache/amoro/server/dashboard/controller/OptimizerGroupController.java
Outdated
Show resolved
Hide resolved
klion26
force-pushed
the
3279-imporve-with-pagehelper
branch
from
9adff28 to
5393cdf
Compare
|
@zhoujinsong @majin1102 could you please have a look at this when you're free, thanks. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3283 +/- ##
============================================
+ Coverage 22.54% 30.17% +7.63%
- Complexity 2312 3841 +1529
============================================
Files 397 580 +183
Lines 38201 48020 +9819
Branches 5437 6207 +770
============================================
+ Hits 8611 14491 +5880
- Misses 28863 32538 +3675
- Partials 727 991 +264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhoujinsong
reviewed
Oct 21, 2024
amoro-ams/src/main/java/org/apache/amoro/server/table/DefaultTableService.java
Show resolved
Hide resolved
klion26
force-pushed
the
3279-imporve-with-pagehelper
branch
2 times, most recently
from
497aa0b to
dbae79c
Compare
… from db Before the change, the total number of optimizing tables with the given filter will be retrieved from memory, this means that we'll retrieve info from two different place, after the change, we'll retrieve the optimizing tables and total result both frm db by using PageHelper.
klion26
force-pushed
the
3279-imporve-with-pagehelper
branch
from
dbae79c to
606837f
Compare
|
@zhoujinsong thanks for the review and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3279
Brief change log
Before the change, the total number of optimizing tables with the given filter will be retrieved from memory, this means that we'll retrieve info from two different place, after the change, we'll retrieve the optimizing tables and total result both frm db by using PageHelper.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation