Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCTIC-714][Bug]: Iceberg tableType not show files tab #719

Merged
merged 29 commits into from
Nov 23, 2022

Conversation

huiyuanz
Copy link
Contributor

@huiyuanz huiyuanz commented Nov 23, 2022

Fix #714

Brief change log

1.Details interface add tableType field
2.Iceberg tableType not show files tab

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Nov 23, 2022
@huiyuanz huiyuanz added this to the Release 0.4.0 milestone Nov 23, 2022
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 9165c28 into apache:master Nov 23, 2022
zhoujinsong pushed a commit that referenced this pull request May 31, 2023
* feat: update introduce content

* feat: revert

* feat: details add tableType field

Co-authored-by: zhubeibei <zhubeibei@corp.netease.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The page content is wrong when opening table detail from the optimizers page for the iceberg table
2 participants