Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Table-size shows 0 while flink continuously writing #823

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

hameizi
Copy link
Contributor

@hameizi hameizi commented Dec 2, 2022

Why are the changes needed?

#819

Brief change log

add table metrics in getTableDetail

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@github-actions github-actions bot added module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Dec 2, 2022
@hameizi hameizi requested a review from Aireed December 2, 2022 09:40
@github-actions github-actions bot added the type:docs Improvements or additions to documentation label Dec 2, 2022
Copy link
Contributor

@Aireed Aireed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aireed Aireed merged commit 8e852d9 into apache:master Dec 2, 2022
zhoujinsong pushed a commit that referenced this pull request May 31, 2023
* add table metrics in getTableDetail

* add table metrics in getTableDetail
@hameizi hameizi deleted the add-table-metric branch July 7, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants