[ARCTIC-920][Optimize] Fix the problem of data inconsistency after minor optimize #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
force refresh the base table when checking the file cache in the base table
github-actions
bot
added
module:ams-server
wangtaohz
reviewed
Dec 12, 2022
ams/ams-server/src/main/java/com/netease/arctic/ams/server/optimize/BaseArcticOptimizePlan.java
Outdated
Show resolved
Hide resolved
added 3 commits
December 12, 2022 19:14
fix review
fix review
1. remove isRunning and use optimize task size to check whether the table is running 2. generate partition running status before getting data files to avoid incorrect plan
wangtaohz
reviewed
Dec 13, 2022
ams/ams-server/src/test/java/com/netease/arctic/ams/server/OptimizeIntegrationTest.java
Outdated
Show resolved
Hide resolved
added 2 commits
December 13, 2022 17:35
fix review
fix review
wangtaohz
approved these changes
Dec 13, 2022
|
LGTM |
This was referenced Apr 21, 2023
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
…nor optimize (#921) * fix #920 1. force refresh the base table when checking the file cache in the base table 2. remove isRunning and use optimize task size to check whether the table is running 3. generate partition running status before getting data files to avoid incorrect plan Co-authored-by: luting <dylzlt93299@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #920
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation