Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if with identical then and else blocks #559

Closed
chavacava opened this issue Oct 2, 2023 · 2 comments
Closed

if with identical then and else blocks #559

chavacava opened this issue Oct 2, 2023 · 2 comments
Assignees
@LinkinStars

Comments

@chavacava
Copy link

https://github.com/answerdev/answer/blob/c34923031da16df9c8a22db57c3b03db63f4f510/internal/repo/activity/answer_repo.go#L290-L294

Either the whole conditional can be replaced by msg.ObjectType = constant.AnswerObjectType or the else branch should be fixed.

(found by revive while testing it on answer code base)
@LinkinStars
Copy link
Member

@chavacava Thanks for the feedback, we will optimise this part of the code.

@LinkinStars LinkinStars self-assigned this Oct 7, 2023
LinkinStars added a commit that referenced this issue Dec 7, 2023
@LinkinStars
fix(activity): remove identical block fix #559
f0ebcaf
@LinkinStars
Copy link
Member

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LinkinStars LinkinStars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LinkinStars @chavacava