Answer issue: 1237 #1238
Merged
Answer issue: 1237 #1238
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahinakyol
commented
Jan 29, 2025
sahinakyol
commented
- Add dependent command 'install-ui-packages' to 'make ui' command
- Add missing old_pass object message to i18n
shuashuai
reviewed
Feb 6, 2025
Makefile
Outdated
| @@ -47,7 +47,7 @@ install-ui-packages: | |||
| @corepack enable | |||
| @corepack prepare pnpm@8.9.2 --activate | |||
|
|
|||
| ui: | |||
| ui: install-ui-packages | |||
| @cd ui && pnpm pre-install && pnpm build && cd - | |||
There was a problem hiding this comment.
I checked the description in your ISSU. You are actually equivalent to using the local development model. The premise of local development is that you need to install the corresponding node、 pnpm 、Golang environment.
docs
Makefile does not need to be modified here, because when executing the Makefile completely , will install pnpm first.
There was a problem hiding this comment.
Hello thanks for review.You are right, I'm going to revert this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.